Detect dynamic register keywords 4683 v4#11036
Closed
catenacyber wants to merge 10 commits intoOISF:masterfrom
Closed
Detect dynamic register keywords 4683 v4#11036catenacyber wants to merge 10 commits intoOISF:masterfrom
catenacyber wants to merge 10 commits intoOISF:masterfrom
Conversation
As this triggers rustc 1.78 unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed `isize::MAX`
If the flow begins with a gap, do not try run probing parsers to recognize app-layer on it, as they have no data.
So that there is no need to remove the final binary, to recompile it if there has been changes in the code.
detect: make number of keywords dynamic Ticket: 4683
Ticket: 4863 On the way, convert unit test DetectSNMPCommunityTest to a SV test. And also, make snmp.pdu_type use a generic uint32 for detection, allowing operators, instead of just equality.
Ticket: 4863
Ticket: 4863
catenacyber
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
|
Information: QA ran without warnings. Pipeline 20534 |
Contributor
Author
|
Rebased in #11068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4683
Describe changes:
>2and suchContinuation of #9871 after merge of #10819
After the merge of loggers, pure rust plugins will need pure rust keywords.
The plan is to do this for all rust app-layers, now only done for 3 protocols, which has both integers and buffers as keywords.
#11035 which should be green CI, plus DHCP and websocket
This is done on top of #11033 commits to get green CI